Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWS Bedrock Chat Model Node): Improve filtering of Bedrock models & fix Claude 3 #9085

Merged
merged 2 commits into from Apr 9, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

This PR fixes an issue where Claude 3 models wouldn't be usable with AWS Bedrock Chat node.

  • Upgrade the Langchain's @langchain/community dependency to enable Claude 3 support
  • Improve filtering of AWS Bedrock Embedding & Chat models by specifying the query parameters(byOutputModality=EMBEDDING and byInferenceType=ON_DEMAND)

CleanShot 2024-04-08 at 14 51 00
CleanShot 2024-04-08 at 14 53 53

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

… & fix Claude 3

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
michael-radency
michael-radency previously approved these changes Apr 9, 2024
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Copy link

cypress bot commented Apr 9, 2024

2 flaky tests on run #4642 ↗︎

0 353 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: f18316e55f
Status: Passed Duration: 03:56 💡
Started: Apr 9, 2024 12:08 PM Ended: Apr 9, 2024 12:12 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #9085 ↗︎

Copy link
Contributor

github-actions bot commented Apr 9, 2024

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit cfaab0b into master Apr 9, 2024
28 checks passed
@OlegIvaniv OlegIvaniv deleted the ai_fix_bedrock branch April 9, 2024 12:22
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
@janober
Copy link
Member

janober commented Apr 10, 2024

Got released with n8n@1.37.0

netroy pushed a commit that referenced this pull request Apr 11, 2024
… & fix Claude 3 (#9085)

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants