New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Prevent duplicate values in preview for SQL editor #9129
fix(editor): Prevent duplicate values in preview for SQL editor #9129
Conversation
packages/editor-ui/src/components/InlineExpressionEditor/InlineExpressionEditorOutput.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolvedExpression
in packages/editor-ui/src/components/ExpressionEditorModal/ExpressionEditorModalOutput.vue
has the exact same code. Do we not need to update there as well?
Good point, I extracted the common logic into a new component |
1 flaky test on run #4735 ↗︎
Details:
cypress/e2e/5-ndv.cy.ts • 1 flaky test
Review all test suite changes for PR #9129 ↗︎ |
✅ All Cypress E2E specs passed |
Got released with |
Summary
SQL query preview should not include duplicates (specifically brackets for this issue).
ExpressionEditorOutput
to not display duplicate segmentsRelated tickets and issues
https://linear.app/n8n/issue/NODE-1286/postgres-sqleditor-duplicate-values-in-preview
https://community.n8n.io/t/postgresql-node-using-array-something-duplicates-the-output/43373
Review / Merge checklist
(no-changelog)
otherwise. (conventions)