Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Update sticky content when checkbox state changes #9596

Merged
merged 17 commits into from
Jun 5, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Jun 3, 2024

Summary

After adding checkbox support to markdown (#9549), this PR will sync underlying markdown on checkbox changes

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included

@MiloradFilipovic MiloradFilipovic self-assigned this Jun 3, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 3, 2024
netroy
netroy previously approved these changes Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ No visual regressions found.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jun 3, 2024

Passing run #5308 ↗︎

0 355 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project: n8n Commit: 6db3838f50
Status: Passed Duration: 04:41 💡
Started: Jun 4, 2024 3:26 PM Ended: Jun 4, 2024 3:31 PM

Review all test suite changes for PR #9596 ↗︎

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ All Cypress E2E specs passed

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

github-actions bot commented Jun 4, 2024

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 5361e9f into master Jun 5, 2024
29 checks passed
@MiloradFilipovic MiloradFilipovic deleted the sticky-checkbox-markdown-sync branch June 5, 2024 07:01
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
@janober
Copy link
Member

janober commented Jun 5, 2024

Got released with n8n@1.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants