Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix AddActivatedAtUserSetting migration on MariaDB #9910

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jul 2, 2024

Summary

Remove unnecessary value casting in the migration query

Related Linear tickets, Github issues, and Community forum posts

Fixes #9907
N8N-7470

Review / Merge checklist

  • PR title and summary are descriptive

@netroy netroy requested a review from a team as a code owner July 2, 2024 09:25
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 2, 2024
@netroy netroy changed the title fix(core): Fix AddActivatedAtUserSetting migration on MySQL/MariaDB fix(core): Fix AddActivatedAtUserSetting migration on MariaDB Jul 2, 2024
@netroy netroy added the release/backport Changes that need to be backported to older releases. label Jul 2, 2024
Copy link

cypress bot commented Jul 2, 2024

2 flaky tests on run #5741 ↗︎

0 399 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: f86010557b
Status: Passed Duration: 04:57 💡
Started: Jul 2, 2024 1:19 PM Ended: Jul 2, 2024 1:24 PM
Flakiness  e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9910 ↗︎

Copy link
Contributor

github-actions bot commented Jul 2, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit db29e84 into master Jul 2, 2024
33 checks passed
@netroy netroy deleted the fix-N8N-7470 branch July 2, 2024 13:25
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with n8n@1.48.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless crashloop after upgrading to latest
3 participants