feat(Zammad Node): Add reply_to and sender fields to article on ticket creation #9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joffcom
reviewed
Jul 2, 2024
packages/nodes-base/nodes/Zammad/descriptions/TicketDescription.ts
Outdated
Show resolved
Hide resolved
Joffcom
requested changes
Jul 2, 2024
n8n-assistant
bot
added
community
|
|
I followed the steps from CONTRIBUTING.md which dos not say anything about linting. I did use VSCode with the ESLint plugin and it does not complain with my changes. I have now also run |
Joffcom
approved these changes
Jul 2, 2024
Merged
|
Got released with |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add two new fields to Zammad articles during Zammad ticket creation:
The new
senderfield allows setting which side has created the article, which always defaulted toAgentpreviously.The new
reply_tofield allows setting a email address for replies that is different from the email address of the user that created the article. This is needed when using a single account to create tickets and articles as otherwise that accounts email address is used for replies.Related Linear tickets, Github issues, and Community forum posts
This PR addresses the FR part of #9807 but not the bug reported in the ticket.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)