Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Make expression autocomplete search case-insensitive #10017

Merged

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jul 11, 2024

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1374/expressions-make-autocomplete-case-insensitive-support-aliases

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 11, 2024
Copy link

cypress bot commented Jul 11, 2024

2 flaky tests on run #5889 ↗︎

0 399 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 0ba6d2cfb6
Status: Passed Duration: 05:37 💡
Started: Jul 11, 2024 3:21 PM Ended: Jul 11, 2024 3:26 PM
Flakiness  e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > should retrieve remote options when non-required params throw errors Screenshots Video

Review all test suite changes for PR #10017 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit cde6fe9 into master Jul 11, 2024
27 checks passed
@elsmr elsmr deleted the node-1374-expressions-make-autocomplete-case-insensitive-support branch July 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants