Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Migrate settings.store to composition API (no-changelog) #10022

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

RicardoE105
Copy link
Contributor

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title Migrate settings.store to composition API refactor(editor): Migrate settings.store to composition API (no-changelog) Jul 12, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 12, 2024
@RicardoE105 RicardoE105 requested a review from elsmr July 13, 2024 17:51
@RicardoE105
Copy link
Contributor Author

RicardoE105 commented Jul 13, 2024

@elsmr, any pointers on why the last test for AssignmentCollection is failing? I know the drop event handler is never called, even though it should be, but I could not figure out why it's not triggered. I wasted already a couple of hours trying to figure it out 😞 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants