Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reddit node to fetch user Saved posts #2575

Closed
wants to merge 12 commits into from
Closed

Update Reddit node to fetch user Saved posts #2575

wants to merge 12 commits into from

Conversation

m4tt72
Copy link
Contributor

@m4tt72 m4tt72 commented Dec 16, 2021

This might contain breaking changes since the User resource on the Reddit node now requires credentials.

Also added a .nvmrc to make it easy for nvm users to switch node version

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2021

CLA assistant check
All committers have signed the CLA.

@ivov ivov added node/improvement New feature or request community Authored by a community member labels Dec 16, 2021
@Joffcom
Copy link
Member

Joffcom commented Mar 23, 2022

Hey @m4tt72,

I have just been reviewing this one and the breaking change bugs me a bit but before I add it to the breaking changes list am I right in thinking you can only get the saved posts of the currently logged in user?

@m4tt72
Copy link
Contributor Author

m4tt72 commented Mar 23, 2022

Hey @m4tt72,

I have just been reviewing this one and the breaking change bugs me a bit but before I add it to the breaking changes list am I right in thinking you can only get the saved posts of the currently logged in user?

Hello @Joffcom,

Correct, this change will allow a logged in reddit user to fetch their saved posts.

I use this to save my saved Reddit posts into a database.

@Joffcom
Copy link
Member

Joffcom commented Mar 23, 2022

Perfect, we were just trying to think about how we can handle it without introducing a breaking where possible.

We have a solution which I will push to this commit shortly 👍

@Joffcom
Copy link
Member

Joffcom commented Mar 23, 2022

Hey @m4tt72,

It wouldn't let me push the changes to this PR, Not sure if that was because you used your master branch instead of making a new branch for the change but what I have done is made a new PR here: #3034 which contains the change you made tweaked a bit 👍🏻

What I will do is close this PR and if you have any questions you can pop them on here or on the new PR, Thanks for spending the time on this PR.

@Joffcom Joffcom closed this Mar 23, 2022
@janober
Copy link
Member

janober commented Mar 27, 2022

Thank you very much for your contribution @m4tt72 ! It got merged with #3034 and will be available with the next version.

@janober janober added the Upcoming Release Will be part of the upcoming release label Mar 27, 2022
@janober
Copy link
Member

janober commented Mar 27, 2022

Got released with n8n@0.170.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants