use state
instead of cid
for oauth1 callback
#3354
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently twitter oauth1.0a could not be authenticated, the error is:
By investigating the code, I found that when /oauth1-credential/callback
is called,
const credential = await getCredentialWithoutUser(credentialId)
failed because
creadentialId
fromreq.query.cid
is nil.This is because twitter api only allowes
state
parameter to be passedround-trip, others like
cid
is ignored, which we passed eariler in/oauth1-credential/auth handler. (Google does the same, AFAIK)
In this PR, I simply changed the parameter name from
cid
tostate
and tested that it can fix this issue.
Though
state
could be a JSON string to hold more data, it's currentlyOK to just be the value of
credentialId
, if we need to add morevalues, we can change
state
to JSON like what has been implemented in/oauth2-credential.