Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Encapsulate canvas actions #4416

Merged
merged 32 commits into from Nov 7, 2022

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 23, 2022

N8N-5144

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 23, 2022
@cstuncsik cstuncsik marked this pull request as ready for review October 24, 2022 05:07
packages/editor-ui/src/store.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/modules/canvas.ts Outdated Show resolved Hide resolved
…e-canvas-controls

# Conflicts:
#	package-lock.json
#	packages/editor-ui/package.json
#	packages/editor-ui/src/store.ts
#	packages/editor-ui/src/views/NodeView.vue
@cstuncsik cstuncsik changed the title refactor(editor): encapsulating canvas actions refactor(editor): Encapsulate canvas actions Nov 4, 2022
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Nice job on composition API and dynamic imports.
Just one thing: I am getting errors when scrolling with mouse wheel:
image

Once that is addressed, it's good to go.

Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good.

@cstuncsik cstuncsik merged commit 350b356 into master Nov 7, 2022
@cstuncsik cstuncsik deleted the n8n-5144-encapsulate-canvas-controls branch November 7, 2022 08:53
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 7, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 7, 2022
* master:
  fix(editor): Showing string numbers and null properly in JSON view (#4513)
  fix(editor): Switch `CodeNodeEditor` linter parser to `esprima-next` (#4524)
  fix(API): Do not use names for typeorm connections (#4532)
  refactor(editor): Encapsulate canvas actions (#4416)
  fix: Database config should resolve entities and migrations folder relative to it's path (no-changelog) (#4527)
  feat(API): Set up error tracking using Sentry (#4394)
  fix(editor): Curb arg linting for `$input.first()` and `$input.last()` (#4526)
  fix(HTTP Request Node): use the data in "Put Output in Field" field (#4487)
  refactor: consolidate database configs (#4522)

# Conflicts:
#	packages/editor-ui/src/views/NodeView.vue
@janober
Copy link
Member

janober commented Nov 10, 2022

Got released with n8n@0.202.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants