Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add support for digestAuth to httpRequest and declarative style #5676

Merged
merged 1 commit into from Apr 19, 2023

Conversation

janober
Copy link
Member

@janober janober commented Mar 12, 2023

We should think about the naming of the option. I simply named it now like it was in the request library.

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/authentication-in-declarative-nodes/23764/5

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 12, 2023
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 7.69% and project coverage change: -0.01 ⚠️

Comparison is base (c6ba0bd) 10.25% compared to head (15f5309) 10.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5676      +/-   ##
==========================================
- Coverage   10.25%   10.25%   -0.01%     
==========================================
  Files        2200     2200              
  Lines       84647    84657      +10     
  Branches    16680    16682       +2     
==========================================
  Hits         8681     8681              
- Misses      75480    75490      +10     
  Partials      486      486              
Impacted Files Coverage Δ
packages/core/src/NodeExecuteFunctions.ts 10.16% <0.00%> (-0.12%) ⬇️
packages/workflow/src/Interfaces.ts 50.00% <ø> (ø)
packages/cli/src/CredentialsHelper.ts 25.24% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janober janober changed the title feat(core): Add support to digestAuth to httpRequest and declarative style feat(core): Add support for digestAuth to httpRequest and declarative style Mar 20, 2023
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@janober janober merged commit 62f993c into master Apr 19, 2023
21 of 23 checks passed
@janober janober deleted the digest-auth-declarative branch April 19, 2023 11:44
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
… style (n8n-io#5676)

feat(core): Add support to digestAuth to httpRequest and declarative style
@janober
Copy link
Member Author

janober commented May 2, 2023

Got released with n8n@0.226.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants