New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HTTP Request Node): Add pagination support #5993
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5993 +/- ##
==========================================
+ Coverage 33.60% 33.75% +0.14%
==========================================
Files 3403 3408 +5
Lines 207709 208594 +885
Branches 22467 22564 +97
==========================================
+ Hits 69795 70401 +606
- Misses 136767 137046 +279
Partials 1147 1147
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be working well with the different APIs I have tested against.
Passing run #2647 ↗︎
Details:
Review all test suite changes for PR #5993 ↗︎ |
✅ All Cypress E2E specs passed |
# [1.15.0](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.0) (2023-11-02) ### Bug Fixes * **core:** Ensure execution deletion in worker lifecycle hook ([#7481](#7481)) ([742c8a8](742c8a8)) * **core:** Fix data encryption on credentials import ([#7560](#7560)) ([b350568](b350568)) * **core:** Fix issue that prevents owner logging in when using ldap ([#7408](#7408)) ([479f902](479f902)) * **core:** Handle missing resultData in runData ([#7523](#7523)) ([1055bd3](1055bd3)) * **core:** Permission check for subworkflow properly checking for workflow settings ([#7576](#7576)) ([437c95e](437c95e)) * **core:** Prevent executions from becoming forever running ([#7569](#7569)) ([9bdb85c](9bdb85c)) * **core:** Upgrade crypto-js to address CVE-2023-46233 ([#7519](#7519)) ([65e5593](65e5593)) * **editor:** Do not truncate form inputs ([#7528](#7528)) ([ae616f1](ae616f1)) * **editor:** Fix NDV close after using input select ([#7544](#7544)) ([3b5e181](3b5e181)) * **editor:** Fix NDV unexpected re-render ([#7532](#7532)) ([2853fcf](2853fcf)) * **editor:** Fix route component caching, incorrect use of array reduce method and enable WF history feature ([#7434](#7434)) ([12a89e6](12a89e6)) * **editor:** Fixes the issue that Switch Node can not be created ([#7516](#7516)) ([df89685](df89685)) * **editor:** Handle `localStorage` being blocked/unavailable ([#7348](#7348)) ([c05bc67](c05bc67)) * **Jira Software Node:** Handle missing issue types in issue types loader ([#7534](#7534)) ([9762705](9762705)) * **Switch Node:** Allow sortable Switch rules ([#7555](#7555)) ([7a56e58](7a56e58)) ### Features * **core:** Add optional Error-Output ([#7460](#7460)) ([655efea](655efea)) * **core:** Make queue mode settings configurable ([#7526](#7526)) ([3d95b24](3d95b24)) * **core:** Set up leader selection for multiple main instances ([#7527](#7527)) ([442c73e](442c73e)) * **editor:** Implement the `UserStack` design system component ([#7559](#7559)) ([ce14f62](ce14f62)) * **HTTP Request Node:** Add pagination support ([#5993](#5993)) ([cc2bd2e](cc2bd2e)) * **HTTP Request Node:** Update icon and default color ([#7572](#7572)) ([ff279ab](ff279ab)) * **n8n Form Trigger Node:** Add text area and password input types ([#7474](#7474)) ([b72040a](b72040a)) * **editor:** Dark mode is here! You can change it under personal settings.([#6980](#6980)) ([0746783](0746783)) --------- Co-authored-by: krynble <krynble@users.noreply.github.com> Co-authored-by: Omar Ajoue <krynble@gmail.com>
## [1.15.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.1) (2023-11-02) ### Bug Fixes * **core:** Ensure execution deletion in worker lifecycle hook ([#7481](#7481)) ([742c8a8](742c8a8)) * **core:** Fix data encryption on credentials import ([#7560](#7560)) ([b350568](b350568)) * **core:** Fix issue that prevents owner logging in when using ldap ([#7408](#7408)) ([479f902](479f902)) * **core:** Handle missing resultData in runData ([#7523](#7523)) ([1055bd3](1055bd3)) * **core:** Permission check for subworkflow properly checking for workflow settings ([#7576](#7576)) ([437c95e](437c95e)) * **core:** Prevent executions from becoming forever running ([#7569](#7569)) ([9bdb85c](9bdb85c)) * **core:** Upgrade crypto-js to address CVE-2023-46233 ([#7519](#7519)) ([65e5593](65e5593)) * **editor:** Do not truncate form inputs ([#7528](#7528)) ([ae616f1](ae616f1)) * **editor:** Fix NDV close after using input select ([#7544](#7544)) ([3b5e181](3b5e181)) * **editor:** Fix NDV unexpected re-render ([#7532](#7532)) ([2853fcf](2853fcf)) * **editor:** Fix route component caching, incorrect use of array reduce method and enable WF history feature ([#7434](#7434)) ([12a89e6](12a89e6)) * **editor:** Fixes the issue that Switch Node can not be created ([#7516](#7516)) ([df89685](df89685)) * **editor:** Handle `localStorage` being blocked/unavailable ([#7348](#7348)) ([c05bc67](c05bc67)) * Fix dark mode small issues ([#7573](#7573)) ([1d81afc](1d81afc)) * **Jira Software Node:** Handle missing issue types in issue types loader ([#7534](#7534)) ([9762705](9762705)) * **Switch Node:** Allow sortable Switch rules ([#7555](#7555)) ([7a56e58](7a56e58)) ### Features * **core:** Add optional Error-Output ([#7460](#7460)) ([655efea](655efea)) * **core:** Make queue mode settings configurable ([#7526](#7526)) ([3d95b24](3d95b24)) * **core:** Set up leader selection for multiple main instances ([#7527](#7527)) ([442c73e](442c73e)) * **editor:** Implement the `UserStack` design system component ([#7559](#7559)) ([ce14f62](ce14f62)) * **HTTP Request Node:** Add pagination support ([#5993](#5993)) ([cc2bd2e](cc2bd2e)) * **HTTP Request Node:** Update icon and default color ([#7572](#7572)) ([ff279ab](ff279ab)) * **n8n Form Trigger Node:** Add text area and password input types ([#7474](#7474)) ([b72040a](b72040a)) * **editor:** Dark mode is here! You can change it under personal settings.([#6980](#6980)) ([0746783](0746783)) --------- Co-authored-by: krynble <krynble@users.noreply.github.com> Co-authored-by: Omar Ajoue <krynble@gmail.com>
Got released with |
Is still WIP and does not implement the correct UI yet.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/pagination-included-into-http-node/15080
https://community.n8n.io/t/how-to-paginate-through-data-in-http-requests/28103