Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add Set up version control CTA #6356

Merged
merged 9 commits into from
Jun 6, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 97.81% and project coverage change: -0.09 ⚠️

Comparison is base (dba3f44) 28.33% compared to head (54779df) 28.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6356      +/-   ##
==========================================
- Coverage   28.33%   28.25%   -0.09%     
==========================================
  Files        2980     2980              
  Lines      184930   184986      +56     
  Branches    20306    20302       -4     
==========================================
- Hits        52406    52264     -142     
- Misses     131738   131935     +197     
- Partials      786      787       +1     
Impacted Files Coverage Δ
...ages/design-system/src/components/N8nMenu/Menu.vue 0.00% <ø> (ø)
...or-ui/src/components/MainSidebarVersionControl.vue 78.70% <97.45%> (-21.30%) ⬇️
packages/editor-ui/src/components/MainSidebar.vue 43.96% <100.00%> (ø)
...kages/editor-ui/src/components/SettingsSidebar.vue 28.29% <100.00%> (+0.84%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cstuncsik cstuncsik requested a review from alexgrozav June 1, 2023 14:51
Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something funky going on in the sidebar, but other than that looks good.

@cstuncsik cstuncsik requested a review from alexgrozav June 5, 2023 05:01
…he-set-up-version-control-cta

# Conflicts:
#	packages/editor-ui/src/components/MainSidebarVersionControl.vue
alexgrozav
alexgrozav previously approved these changes Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jun 6, 2023

Passing run #1118 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 pay-470-implement-the-set-up-version-control-cta 🖥️ browsers:node18.12.0-chr...
Project: n8n Commit: 54779df927
Status: Passed Duration: 07:07 💡
Started: Jun 6, 2023 12:04 PM Ended: Jun 6, 2023 12:11 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

alexgrozav
alexgrozav previously approved these changes Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit e72521d into master Jun 6, 2023
54 of 55 checks passed
@cstuncsik cstuncsik deleted the pay-470-implement-the-set-up-version-control-cta branch June 6, 2023 12:27
MiloradFilipovic added a commit that referenced this pull request Jun 13, 2023
* master:
  test(editor): Unit test Version control frontend components (#6408)
  fix: Fist name to First Name in certain nodes (no-changelog) (#6404)
  fix(core): Allow all executions to be stopped (#6386)
  fix(core): RMC boolean value fix (#6397)
  fix(editor): Remove root level tag selector from css module to avoid making it a global style (#6392)
  fix(Ldap Node): Add DN field to update operation (#6371)
  feat: New trigger PostgreSQL  (#5495)
  build: Update pnpm lock file (no-changelog) (#6395)
  fix(Date & Time Node): Reset responseData at end of loop (#6385)
  refactor(core): Google service account remove duplicated functions (no-changelog) (#6368)
  refactor(LoneScale List Node)!: Rename to LoneScale (#6337)
  fix(editor): Update version control setup CTA tooltip (#6393)
  ci: Fix build (no-changelog) (#6391)
  fix(editor): Add button to refresh branches (#6387)
  fix(editor): Add Set up version control CTA (#6356)
  fix(editor): Remove explicit parameter name scanning for code editors (#6390)
  ci: Fix build (no-changelog) (#6379)
  fix(editor): Adding branch color (#6380)
  refactor(editor): Remove user activation modal (no-changelog) (#6361)
  feat(editor): Change upgrade CTA on community editions (no-changelog) (#6317)
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with n8n@0.232.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants