Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework of seatable-n8n-node #7517

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

christophdb
Copy link

Complete rework of the SeaTable Node.

  • Adding two new triggers and 10 new actions.
  • Actions use now versioning
  • cleaner code structure
  • already published and tested as community node (n8n-nodes-seatable)

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request node/new Creation of an entirely new node labels Oct 26, 2023
@christophdb
Copy link
Author

Bump this Merge Request. Is there anything I can do to support the review of this PR?

@MehrCurry
Copy link

I wonder why this important change is delayed that long. As a user of n8n cloud i am waiting for the change. The community module is not an option for us cloud users.

@janober
Copy link
Member

janober commented Apr 3, 2024

What is still outstanding @Joffcom ?

@Joffcom
Copy link
Member

Joffcom commented Apr 3, 2024

I will need to run through it again but I think it was a bunch of lint issues that I wasn’t able to push changes for.

@MehrCurry
Copy link

MehrCurry commented Apr 11, 2024

I tried the seatable community module on a self-hosted instance with docker on my machine. Exactly what i need. So this means i must switch from the n8n cloud solution to a self-hosted instance to get seatable usable. I was using a workaround with a scheduled trigger but that quickly exceeds the limit of my cloud subscription.

@Joffcom
Copy link
Member

Joffcom commented Apr 15, 2024

Hey @MehrCurry,

Sadly for now that would be the case as we have to ensure any PR follows our code standards before accepting it.

@MehrCurry
Copy link

Hey @MehrCurry,

Sadly for now that would be the case as we have to ensure any PR follows our code standards before accepting it.

I am working as a senior software architect and i would not recommend lowering the coding standards. But its sad to see this branch dying which already contains important enhancements. I love using n8n and i also like using Seatable but the current status makes them more or less unusable together.

Anyway thanks for your help.

@Joffcom
Copy link
Member

Joffcom commented Apr 24, 2024

Hey @MehrCurry,

We will get this sorted, I have blocked out some time next week to see if I can push to this branch again to go through the lint issues.

@MehrCurry
Copy link

Hey @Joffcom,

i am really glad and exited to hear that. I very much appreciate your work. Keep going.

Regards
Guido

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request node/new Creation of an entirely new node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants