Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ado 1296 add e2e tests #7792

Merged
merged 2 commits into from
Nov 27, 2023
Merged

test: Ado 1296 add e2e tests #7792

merged 2 commits into from
Nov 27, 2023

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Nov 23, 2023

Adds e2e tests for the template credential setup.

Builds on top of this root PR

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 23, 2023
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

cypress/e2e/34-template-credentials-setup.cy.ts Outdated Show resolved Hide resolved
Base automatically changed from ado-1296-move-credential-setup-behind-feature-flag to ado-1296-spike-credential-setup-in-templates November 27, 2023 12:31
@tomi
Copy link
Contributor Author

tomi commented Nov 27, 2023

Resolved conflicts and rebased on top of base branch. No code changes. Could you reapprove @MiloradFilipovic 🙏

Base automatically changed from ado-1296-spike-credential-setup-in-templates to master November 27, 2023 14:30
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve after merge

Copy link

cypress bot commented Nov 27, 2023

Passing run #3046 ↗︎

0 288 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project: n8n Commit: e2aad2bf42
Status: Passed Duration: 05:54 💡
Started: Nov 27, 2023 2:43 PM Ended: Nov 27, 2023 2:49 PM

Review all test suite changes for PR #7792 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi merged commit ac744d6 into master Nov 27, 2023
19 checks passed
@tomi tomi deleted the ado-1296-add-e2e-tests branch November 27, 2023 15:18
@janober
Copy link
Member

janober commented Dec 1, 2023

Got released with n8n@1.19.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants