Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): Make user controller tests faster (no-changelog) #7819

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 27, 2023

Before: 17.949 s
After: 3.886 s

Followup to: #7797 (comment)

@ivov ivov changed the title perf(core) Speed up user controller tests (no-changelog) perf(core): Speed up user controller tests (no-changelog) Nov 27, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 27, 2023
@ivov ivov changed the title perf(core): Speed up user controller tests (no-changelog) perf(core): Make user controller tests faster (no-changelog) Nov 27, 2023
Copy link

cypress bot commented Nov 27, 2023

1 flaky test on run #3032 ↗︎

0 283 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: dc6d2cfd79
Status: Passed Duration: 07:04 💡
Started: Nov 27, 2023 10:48 AM Ended: Nov 27, 2023 10:55 AM
Flakiness  cypress/e2e/12-canvas.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should add merge node and test connections Screenshots Video

Review all test suite changes for PR #7819 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 75a5807 into master Nov 27, 2023
19 of 22 checks passed
@ivov ivov deleted the speed-up-user-controller-tests branch November 27, 2023 10:56
@janober
Copy link
Member

janober commented Dec 1, 2023

Got released with n8n@1.19.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants