Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AI nodes usability fixes + Summarization Chain V2 #7949

Merged
merged 28 commits into from
Dec 8, 2023
Merged

feat: AI nodes usability fixes + Summarization Chain V2 #7949

merged 28 commits into from
Dec 8, 2023

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Dec 7, 2023 •
edited

Fixes:

  • Refactor connection snapping when dragging and enable it also for non-main connection types
  • Fix propagation of errors from sub-nodes
  • Fix chat scrolling when sending/receiving messages
  • Prevent empty chat messages
  • Fix sub-node selected styles
  • Fix output names text overflow

Usability improvements:

  • Auto-add manual chat trigger for agents & chain nodes
  • Various labels and description updates
  • Make the output parser input optional for Basic LLM Chain
  • Summarization Chain V2 with a simplified document loader & text chunking mode

How to test the change:

Example workflow showcasing different operation mode of the new summarization chain:
Summarization_V2.json

Issues fixed

Include links to Github issue or Community forum post or Linear ticket:

Important in order to close automatically and provide context to reviewers

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

    (internal) You can use Slack commands to trigger e2e tests or deploy test instance or deploy early access version on Cloud.

@OlegIvaniv
💄Fix sub-nodes selected state & output labels
6ed7a27 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
✨ Add chat trigger automatically for compatible nodes
5fa388c 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
✨ Optionally toggle output parser in ChainLlm
751ec26 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🐛 Fix input output canvas drag snapping and allow for non-main
5e73056 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🐛 Adjust snapping radius
34c0abd 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🐛 Prevent running workflows with issues
c0aac60 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
✨ Summarization node v2
3cb4bb4 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into n8n-7070-ux-fixes-batch_master
ac61cb1
@OlegIvaniv
Accept binary key as param
d0dbeb4 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into n8n-7070-ux-fixes-batch_master
99b65ec
@OlegIvaniv
🐛 Fix RunDataAI markdown content and default summary data key
42ab473 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🎨 Cleanup
10e51a9 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into n8n-7070-ux-fixes-batch_master
119bc75
@OlegIvaniv
🔧 Update wording and options structure for various chains
5d65e85 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🥅 Correctly propagate errors from sub-nodes
6602920 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🐛 Add manual chat trigger node also for OpenAI assistant
a8caf6b 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🐛 Fix chat modal latest message scrolling
abc998f 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🐛 Keep only a single globalLinkAction handler
b8e0a1b 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🐛 Fix opening of selective node creator from custom action
c7a2bba 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🐛 refresh issues before executing
02e33d3 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
🎨 Improve connection snapping for multi-main input nodes
78b2367 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv self-assigned this Dec 7, 2023
@cypress Cypress
Copy link

cypress bot commented Dec 7, 2023 •
edited

Passing run #3267 ↗︎

0 297 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: 8cd8cfaf05
Status: Passed Duration: 06:19 💡
Started: Dec 8, 2023 11:36 AM Ended: Dec 8, 2023 11:43 AM

Review all test suite changes for PR #7949 ↗︎

@OlegIvaniv
🥅 Improve propagation of sub-nodes errors
e709f3b 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 7, 2023
@OlegIvaniv OlegIvaniv force-pushed the n8n-7070-ux-fixes-batch_master branch from b1f1d80 to ec2cfe9 Compare December 7, 2023 12:20
@OlegIvaniv
🚨Linting fixes
8734070 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv force-pushed the n8n-7070-ux-fixes-batch_master branch from ec2cfe9 to 8734070 Compare December 7, 2023 12:32
@OlegIvaniv
Mock Element.prototype.scrollIntoView for unit tests run
a20e9bf 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv marked this pull request as ready for review December 7, 2023 12:39
@OlegIvaniv
🐛 Use overrideTargetEndpoint index to correctly connect input
b0c4316 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv force-pushed the n8n-7070-ux-fixes-batch_master branch from 06c60b0 to b0c4316 Compare December 7, 2023 13:16
@OlegIvaniv
🚨Linting fixes
16b54d8 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv force-pushed the n8n-7070-ux-fixes-batch_master branch from fbae540 to 16b54d8 Compare December 7, 2023 14:01
OlegIvaniv and others added 2 commits December 8, 2023 09:20
@OlegIvaniv
🚨Linting fixes
3efbee0 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@elsmr
Fix node options styling
8cd8cfa
@elsmr
Copy link
Member

elsmr commented Dec 8, 2023

I pushed a small styling fix for the node options on configurable nodes (was shifted too much to the left):

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit dcf1286 into master Dec 8, 2023
21 checks passed
@OlegIvaniv OlegIvaniv deleted the n8n-7070-ux-fixes-batch_master branch December 8, 2023 12:42
This was referenced Dec 13, 2023
Closed
Merged
ivov added a commit that referenced this pull request Dec 13, 2023
@github-actions @ivov
🚀 Release 1.21.0 (#8019)
1516c84 
#
[1.21.0](https://github.com/n8n-io/n8n/compare/n8n@1.20.0...n8n@1.21.0)
(2023-12-13)


### Bug Fixes

* **core:** Ensure inviter and invitee are set correctly in invite link
([#7943](#7943))
([386bd61](386bd61))
* **core:** Fix user comparison in same-user subworkflow caller policy
([#7913](#7913))
([92bab72](92bab72))
* **core:** Perform multi-main leader check against key ID
([#7964](#7964))
([1a87f70](1a87f70))
* **core:** Ensure external hooks post workflow execute run in queue
mode ([#7947](#7947))
([3ba7deb](3ba7deb))
* **core:** Fix issue preventing secrets from loading if the path
contains - or / ([#7988](#7988))
([0ac9594](0ac9594))
* **core:** Restrict updating/deleting of shared but not owned
credentials ([#7950](#7950))
([42e828d](42e828d))
* **core:** Prevent workflow history saving error from happening
([#7812](#7812))
([e5581ce](e5581ce))
* **editor:** Add missing string for worker in log streaming
([#7971](#7971))
([148bc1d](148bc1d))
* **editor:** Allow SSH protocol in git repository URL for environments
([#7944](#7944))
([bc1c72f](bc1c72f))
* **editor:** Fix bug with node names with certain characters
([#8013](#8013))
([26f0d57](26f0d57))
* **editor:** Fix Webhook URL expansion icon
([#8011](#8011))
([b00b905](b00b905))
* **editor:** Prevent opening NDV search if `/` is typed in a
contenteditable element
([#7968](#7968))
([e8a493f](e8a493f))
* **editor:** Return early in ws message handler if no 'command' keyword
is found ([#7946](#7946))
([5b2defc](5b2defc))
* **FileMaker Node:** Prevent erroring on zero fields loaded
([#7955](#7955))
([10ad386](10ad386))
* **Google Sheets Node:** Prevent erroring on zero sheet search results
([#7957](#7957))
([9b877a9](9b877a9))
* **Google Sheets Node:** Prevent erroring when fetching mapping columns
([#7972](#7972))
([29a1066](29a1066))
* **Postgres Node:** Do not include id column in upsert fields selection
if it's not unique ([#7975](#7975))
([435392c](435392c))
* **Postgres Trigger Node:** Increase manual trigger timeout from 30 to
60 seconds ([#8015](#8015))
([09a5729](09a5729))
* **Webhook Node:** Binary data handling
([#7804](#7804))
([565b409](565b409))
* **Webhook Node:** Do not create binary data when there is no data in
the request ([#8000](#8000))
([70f0755](70f0755))


### Features

* **core:** Add config option for external secret update interval
([#7995](#7995))
([b6c1c04](b6c1c04))
* AI nodes usability fixes + Summarization Chain V2
([#7949](#7949))
([dcf1286](dcf1286))
* **editor:** Data transformation nodes and actions in Nodes Panel
([#7760](#7760))
([675ec21](675ec21))
* **editor:** Add AppCues tracking for onboarding event
([#7945](#7945))
([04cabaf](04cabaf))
* **editor:** Add option to disable NDV in workflow previews
([#7990](#7990))
([393afef](393afef))
* **editor:** Filter component + implement in If node
([#7490](#7490))
([8a53434](8a53434))
* **editor:** Show template credential setup based on feature flag
([#7989](#7989))
([08ee307](08ee307))
* **editor:** Introduce advanced permissions
([#7844](#7844))
([dbd62a4](dbd62a4))
* **Google Ads Node:** Update to support v15
([#7962](#7962))
([7f01269](7f01269))
* **Local File Trigger Node:** Add polling option typically good to
watch network files/folders
([#7942](#7942))
([2fbdfec](2fbdfec))
* **n8n Form Trigger Node:** Improvements
([#7571](#7571))
([953a58f](953a58f))

Co-authored-by: ivov <ivov@users.noreply.github.com>
@janober
Copy link
Member

janober commented Dec 13, 2023

Got released with n8n@1.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsmr elsmr elsmr approved these changes

Assignees

@OlegIvaniv OlegIvaniv

Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OlegIvaniv @elsmr @janober