Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Jira Trigger Node): Add support for Jira webhook signatures #8822

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pemontto
Copy link
Contributor

@pemontto pemontto commented Mar 6, 2024

Summary

This PR adds support for Jira Webhook signatures based on websub

Effectively we generate a random secret when we create the webhook with the same character set and length as the default Atlassian generated secrets. https://developer.atlassian.com/cloud/jira/platform/webhooks/#secure-admin-webhooks

This PR allows using signature auth, query auth, both, or none.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • [] Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Mar 6, 2024
@Joffcom
Copy link
Member

Joffcom commented Mar 6, 2024

@pemontto is this a breaking change?

@pemontto
Copy link
Contributor Author

pemontto commented Mar 6, 2024

It shouldn't be, but there may be edge cases. In my limited simulated updated node testing nothing broke. However thinking of it now, if webhooks don't re-register a guard might be useful to check we actually have a value for webhookData.secret before trying to HMAC and compare on receive.

@Joffcom
Copy link
Member

Joffcom commented Mar 6, 2024

What about the change from options to multioptions or does that not impact anything? We do have another node where we recently introduced the secret option, It could be worth following a similar pattern to that.

@maspio Do you remember which trigger node you added signatures to recently?

@Joffcom Joffcom changed the title feat(Jira Trigger Node):🔒 Add support for Jira webhook signatures feat(Jira Trigger Node): Add support for Jira webhook signatures Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants