Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add type information to autocomplete dropdown #8843

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Mar 8, 2024

Summary

Add type of autocomplete options (only for fields within the $json object)

image

Related tickets and issues

https://linear.app/n8n/issue/NODE-1148/add-type-information-to-autocomplete-list

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 8, 2024
OlegIvaniv
OlegIvaniv previously approved these changes Mar 19, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Mar 19, 2024

2 flaky tests on run #4420 ↗︎

0 343 12 0 Flakiness 2

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: d7bfd45333
Status: Passed Duration: 03:49 💡
Started: Mar 20, 2024 3:10 AM Ended: Mar 20, 2024 3:14 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video

Review all test suite changes for PR #8843 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit d7bfd45 into master Mar 19, 2024
28 checks passed
@elsmr elsmr deleted the node-1148-add-type-information-to-autocomplete-list branch March 19, 2024 17:10
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
@janober
Copy link
Member

janober commented Mar 20, 2024

Got released with n8n@1.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants