Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Notion Node): Regex for block id #8860

Merged

Conversation

michael-radency
Copy link
Contributor

Summary

URL don't work with block:getChildBlocks (and probably other block operations): it's treated as the parent page rather than the block

Related tickets and issues

https://linear.app/n8n/issue/NODE-1202/notion-url-dont-work-with-blockgetchildblocks

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Mar 11, 2024
Copy link

cypress bot commented Mar 13, 2024

Passing run #4361 ↗︎

0 343 12 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 0592dfe002
Status: Passed Duration: 03:48 💡
Started: Mar 13, 2024 11:43 AM Ended: Mar 13, 2024 11:47 AM

Review all test suite changes for PR #8860 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit a1f6c57 into master Mar 13, 2024
28 checks passed
@michael-radency michael-radency deleted the node-1202-notion-url-dont-work-with-blockgetchildblocks branch March 13, 2024 11:57
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
@janober
Copy link
Member

janober commented Mar 13, 2024

Got released with n8n@1.33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants