Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix issue with case insensitive tags #9071

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix(editor): Fix issue with case insensitive tags #9071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b003f8c
Fix issue with case sensitive tags
RicardoE105 Apr 5, 2024
1a7b2b9
update test to cover case insensitivity
RicardoE105 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/e2e/17-workflow-tags.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('Workflow tags', () => {
wf.actions.addTags(TEST_TAGS.slice(0, 2));
wf.getters.tagPills().should('have.length', 2);
wf.getters.nthTagPill(1).click();
wf.actions.addTags(TEST_TAGS[2]);
wf.actions.addTags(TEST_TAGS[1].toUpperCase());
wf.getters.tagPills().should('have.length', 3);
wf.getters.isWorkflowSaved();
});
Expand Down
6 changes: 2 additions & 4 deletions packages/editor-ui/src/components/TagsDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,7 @@ export default defineComponent({
});

const options = computed<ITag[]>(() => {
return allTags.value.filter(
(tag: ITag) => tag && tag.name.toLowerCase().includes(filter.value.toLowerCase()),
);
return allTags.value.filter((tag: ITag) => tag && tag.name.includes(filter.value));
});

const appliedTags = computed<string[]>(() => {
Expand Down Expand Up @@ -182,7 +180,7 @@ export default defineComponent({
}

function filterOptions(value = '') {
filter.value = value.trim();
filter.value = value;
void nextTick(() => focusFirstOption());
}

Expand Down