-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Create a personal project if a user signs up via SAML #9310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
May 6, 2024
despairblue
commented
May 6, 2024
despairblue
force-pushed
the
fix-ldap-user-creation
branch
from
May 6, 2024 14:41
744e220
to
9578819
Compare
krynble
approved these changes
May 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this PR a personal project is also created for users that are created via SAML.
This is best reviewed commit by commit.
Additionally there is a small fix that makes sure that SAML errors contain the message from samlify, instead of just
undefined
.I also refactored
createUserFromSamlAttributes
to run inside a transaction, so that either the user, project and auth identity are created, or nothing. I removed some code that was unnecessary according to the types.Related tickets and issues
none
Review / Merge checklist
(no-changelog)
otherwise. (conventions)