Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Benchmark expressions #9356

Closed
wants to merge 1 commit into from

Conversation

ivov
Copy link
Contributor

@ivov ivov commented May 10, 2024

WIP

Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #9356 will degrade performances by 65.2%

Comparing benchmark-expressions (f13fe59) with benchmark-nodes-base-v2 (34efe10)

Summary

⚡ 10 improvements
❌ 5 regressions
✅ 78 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark benchmark-nodes-base-v2 benchmark-expressions Change
nodes/Aws/S3/test/V1/AwsS3.file.upload.V1.workflow 46.2 ms 91.6 ms -49.54%
nodes/Aws/S3/test/V2/AwsS3.file.upload.V2.workflow 46.2 ms 132.8 ms -65.2%
nodes/Discord/test/v2/node/message/getAll.workflow 63.9 ms 49.3 ms +29.77%
nodes/Discord/test/v2/node/message/send.workflow 52.1 ms 66.6 ms -21.8%
nodes/Files/ConvertToFile/test/toText.workflow 70 ms 51.5 ms +36.1%
nodes/Files/ReadWriteFile/test/ReadWriteFile.workflow 168.1 ms 5 ms ×34
nodes/Microsoft/Excel/test/v2/node/table/append.workflow 45.6 ms 21.1 ms ×2.2
nodes/Microsoft/Excel/test/v2/node/table/convertToRange.workflow 18.6 ms 35 ms -46.81%
nodes/Microsoft/Excel/test/v2/node/workbook/getAll.workflow 24.3 ms 17.4 ms +40.3%
nodes/Microsoft/Excel/test/v2/node/worksheet/deleteWorksheet.workflow 29.7 ms 26.5 ms +11.99%
nodes/Microsoft/Excel/test/v2/node/worksheet/update.workflow 44.1 ms 37.8 ms +16.6%
nodes/MoveBinaryData/test/MoveBinaryData.workflow 22 ms 15.8 ms +39.23%
nodes/MySql/test/v1/executeQuery.workflow 147.1 ms 13 ms ×11
nodes/Set/test/Set.workflow 67.7 ms 50.2 ms +34.77%
nodes/Switch/V2/test/switch.rules.workflow 58.8 ms 136.1 ms -56.76%

@ivov ivov changed the base branch from benchmark-nodes-base-v2 to master May 10, 2024 11:26
@ivov ivov changed the base branch from master to benchmark-nodes-base-v2 May 10, 2024 11:26
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 10, 2024
@ivov
Copy link
Contributor Author

ivov commented May 10, 2024

This PR showed we need to reduce variance in nodes-base benchmarks, closing for now.

@ivov ivov closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant