Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add tests for license manager reinit method #9471

Merged
merged 2 commits into from
May 22, 2024
Merged

test: Add tests for license manager reinit method #9471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06576db
test: Add tests for license manager reinit method
krynble May 20, 2024
8698ed2
fix: More complete test
krynble May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/cli/test/unit/License.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,4 +252,20 @@ describe('License', () => {
});
});
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for completeness, would be good to have a test of init called with recreate true

Copy link
Contributor Author

@krynble krynble May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added additional assertion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant a separate unit test for init called with recreate = true

it('initializes again if recreate is true', () => {
  ...
  license.init('main', true);
  ...

describe('reinit', () => {
it('should reinitialize license manager', async () => {
const license = new License(mock(), mock(), mock(), mock(), mock());
await license.init();
ivov marked this conversation as resolved.
Show resolved Hide resolved

const initSpy = jest.spyOn(license, 'init');

await license.reinit();

expect(initSpy).toHaveBeenCalledWith('main', true);

expect(LicenseManager.prototype.reset).toHaveBeenCalled();
expect(LicenseManager.prototype.initialize).toHaveBeenCalled();
});
});
});
Loading