Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LinkedIn Node): Fix issue with legacy credential no longer working #9912

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jul 2, 2024

Summary

Fixes an issue that prevented the legacy credential from correctly loading Person Name / ID.

Tested with sending an image using Legacy / non-legacy and community management credentials.

OAuth With Legacy
li_test_legacy

OAuth with legacy disabled
li_test_non-legacy

Community Management API
li_test_community_management_api

Related Linear tickets, Github issues, and Community forum posts

https://community.n8n.io/t/linkedin-403-forbidden-error-when-posting-as-person/49269

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jul 2, 2024

4 flaky tests on run #5744 ↗︎

0 399 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 0cf410ae7a
Status: Passed Duration: 05:26 💡
Started: Jul 2, 2024 2:58 PM Ended: Jul 2, 2024 3:04 PM
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > should retrieve remote options when non-required params throw errors Screenshots Video

Review all test suite changes for PR #9912 ↗︎

Copy link
Contributor

github-actions bot commented Jul 2, 2024

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 873b7e5 into master Jul 2, 2024
27 checks passed
@Joffcom Joffcom deleted the linkedin-legacy-fix branch July 2, 2024 15:45
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with n8n@1.49.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants