Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add stop current execution button in new canvas (no-changelog) #9968

Conversation

alexgrozav
Copy link
Contributor

@alexgrozav alexgrozav commented Jul 8, 2024

Summary

Adds stop current execution button.

Screen.Recording.2024-07-08.at.14.43.36.mov
Screen.Recording.2024-07-08.at.15.11.53.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7486/as-a-user-i-want-to-be-able-to-stop-a-long-running-execution

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jul 8, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 8, 2024
OlegIvaniv
OlegIvaniv previously approved these changes Jul 10, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 10, 2024

3 flaky tests on run #5860 ↗︎

0 399 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: 9495618d99
Status: Passed Duration: 04:59 💡
Started: Jul 10, 2024 8:47 AM Ended: Jul 10, 2024 8:52 AM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video

Review all test suite changes for PR #9968 ↗︎

@alexgrozav alexgrozav merged commit 2107de2 into master Jul 10, 2024
28 checks passed
@alexgrozav alexgrozav deleted the n8n-7486-as-a-user-i-want-to-be-able-to-stop-a-long-running-execution branch July 10, 2024 08:53
@janober
Copy link
Member

janober commented Jul 10, 2024

Got released with n8n@1.50.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants