fix: add variable polyfill exceptions for compatiability

n8n-io · Aug 29, 2023 · 2e49c9e · 2e49c9e
1 parent caa15ff
commit 2e49c9e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/VariablePolyfill.ts b/src/VariablePolyfill.ts
@@ -39,6 +39,8 @@ const isInScope = (path: NodePath<types.namedTypes.Identifier>) => {
 	return false;
 };
 
+const polyfillExceptions = ['this', 'window', 'global'];
+
 const polyfillVar = (
 	path: NodePath<types.namedTypes.Identifier>,
 	dataNode: DataNode,
@@ -50,6 +52,10 @@ const polyfillVar = (
 			return;
 		}
 	}
+	// For tmpl compat we ignore these identifiers
+	if (polyfillExceptions.includes(path.node.name)) {
+		return;
+	}
 	path.replace(buildGlobalSwitch(path.node, dataNode));
 };
 

diff --git a/test/ExpressionFixtures/base.ts b/test/ExpressionFixtures/base.ts
@@ -811,4 +811,19 @@ line`,
 		tests: [],
 	},
 	{ expression: '={{ `\ntesting\ntesting\n` }}', tests: [] },
+	{ expression: '={{ new Date }}', tests: [] },
+	{ expression: '={{ new Date() }}', tests: [] },
+	{ expression: '={{ new Date.toISOString() }}', tests: [] },
+	{ expression: '={{ new Date().toISOString() }}', tests: [] },
+	{ expression: '={{ global.test = 3 }}', tests: [] },
+	{ expression: '={{ window.test = 3 }}', tests: [] },
+	{ expression: '={{ this.test = 3 }}', tests: [] },
+	{
+		expression: `=test
+		a
+{{ "test" }}
+{{ test }}
+`,
+		tests: [],
+	},
 ];