feat: Plugable evaluators #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valya
force-pushed
the
plugable-evaluators
branch
from
f5ec130
to
c0b9d7b
Compare
ivov
previously approved these changes
Aug 31, 2023
test/utils.ts
Outdated
| test(t.expression, () => { | ||
| for (const test of t.tests.filter( | ||
| (test_) => test_.type === 'evaluation', | ||
| ) as ExpressionTestEvaluation[]) { |
There was a problem hiding this comment.
You can also use a predicate here instead of asserting.
ivov
approved these changes
Aug 31, 2023
Comment on lines
+8
to
+12
| (e) => { | ||
| console.error(e); | ||
| }, | ||
| undefined, | ||
| Evaluator, |
There was a problem hiding this comment.
Nothing to address now but maybe the args would be nicer as an object in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.