Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger time should be moved later in the sweep to capture more pre-trigger time #45

Open
michaelpeshkin opened this issue Oct 26, 2023 · 2 comments
Assignees

Comments

@michaelpeshkin
Copy link

Trigger, need some on-face indication of which trace is connected to trigger. Best, the “T” tab color should match the selected channel, and it would be good if the up/down arrow were repeated there too: T↑ or T↓. Dotted line, white is good, but something that doesn’t get hidden behind a channel trace. Hatched? Also, can you move the trigger-time from one-div to two-div? I agree it does not need to be adjustable, that’s occasionally useful but not worth the complexity.

@davidjmeyer
Copy link
Member

Added the channel color to trigger flag as part of #44. Trigger time seems limited to one div on nScope v1, so we'll need to look at firmware changes for that.

Is it really preferable that the trigger dotted lines are drawn on top of the scope traces?

@davidjmeyer davidjmeyer self-assigned this Nov 8, 2023
@davidjmeyer davidjmeyer changed the title Trigger Trigger interface could use improvements to clarity and pre-trigger capture time Nov 8, 2023
@davidjmeyer
Copy link
Member

Ah, yes it actually looks much clearer with the trigger-lines on top, but thinner. Done as part of #52

@davidjmeyer davidjmeyer changed the title Trigger interface could use improvements to clarity and pre-trigger capture time Trigger time should be moved later in the sweep to capture more pre-trigger time Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants