Fix for #217 GettingStarted enhancement. #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avamander
added a commit
that referenced
this pull request
Feb 20, 2016
Fix for #217 GettingStarted enhancement.
|
This is not a 'fix' for anything, and in my opinion only confuses things much more so. The sketch was changed to use a 'unique identifier' to demonstrate best practice in radio addressing. The role is dynamic, and changing both the reading and writing pipe when changing the role is not what I would consider 'best practice'. This is because this behaviour is cannot really be extended to more than two devices. My recommendation is to revert this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ravi0li, can you please retest if that fix works with your boards?