available() could be slightly faster #631 #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bndy5
approved these changes
Oct 17, 2020
|
I don't want to overstep (again?! -- don't know why the org went on "pause", but I'm assuming it was me merging the attiny SPI core changes). I've been testing these changes on my fork, and I've had no problems. Looking for a second opinion before merging this. Since my fork depends on these changes, I'm holding off on opening a PR to address the other umpteen issues I've raised... |
|
The pause was due to me and some issues with keeping up to you guys, don’t read into it too much. You are doing great!
… On Oct 27, 2020, at 4:27 AM, Brendan ***@***.***> wrote:
I don't want to overstep (again?! -- don't know why the org went on "pause", but I'm assuming it was me merging the attiny SPI core changes). I've been testing these changes on my fork, and I've had no problems. Looking for a second opinion before merging this.
Since my fork depends on these changes, I'm holding off on opening a PR to address the other umpteen issues I've raised...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rearranged the suggested code slightly. Seems to work OK.
Tested between Uno and Pro Mini using the pingpair_ack sketch.