Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Community appreciation #735

Merged
merged 4 commits into from Feb 26, 2021
Merged

Community appreciation #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e56379
fix changes that sparked frustration in community
2bndy5 Feb 26, 2021
81b3ac6
disable building WiringPi
2bndy5 Feb 26, 2021
33541ed
ammend comment
2bndy5 Feb 26, 2021
3c69e26
ammend another comment
2bndy5 Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_linux.yml
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ jobs:
config-options:
- "--soc=BCM2835 --driver=RPi"
- "--soc=BCM2836 --driver=RPi"
- "--soc=BCM2835 --driver=wiringPi --extra-cflags=-I/usr/local/include"
# - "--soc=BCM2835 --driver=wiringPi --extra-cflags=-I/usr/local/include"
- "--driver=SPIDEV"

steps:
Expand All @@ -28,7 +28,7 @@ jobs:
- name: provide WiringPi
if: ${{ matrix.config-options == '--soc=BCM2835 --driver=wiringPi --extra-cflags=-I/usr/local/include' }}
run: |
git clone https://github.com/CoRfr/WiringPi
git clone https://github.com/WiringPi/WiringPi
cd WiringPi/wiringPi
CC="arm-linux-gnueabihf-gcc -marm -mtune=arm1176jzf-s -mfpu=vfp -mfloat-abi=hard" V=1 make -j5
sudo make install
Expand Down
6 changes: 3 additions & 3 deletions RF24.cpp
View file
Open in desktop
Expand Up @@ -754,7 +754,7 @@ bool RF24::begin(void)
write_register(DYNPD, 0); // disable dynamic payloads by default (for all pipes)
dynamic_payloads_enabled = false;
write_register(EN_AA, 0x3F); // enable auto-ack on all pipes
write_register(EN_RXADDR, 0); // close all RX pipes
write_register(EN_RXADDR, 3); // only open RX pipes 0 & 1
setPayloadSize(32); // set static payload size to 32 (max) bytes by default
setAddressWidth(5); // set default address length to (max) 5 bytes

Expand Down Expand Up @@ -1354,8 +1354,8 @@ void RF24::enableAckPayload(void)

IF_SERIAL_DEBUG(printf("FEATURE=%i\r\n", read_register(FEATURE)));

// Enable dynamic payload on pipes 0
write_register(DYNPD, read_register(DYNPD) | _BV(DPL_P0));
// Enable dynamic payload on pipes 0 & 1
write_register(DYNPD, read_register(DYNPD) | _BV(DPL_P1) | _BV(DPL_P0));
dynamic_payloads_enabled = true;
ack_payloads_enabled = true;
}
Expand Down