GPIO V2 API changes #944
Closed
GPIO V2 API changes #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Click here for the full clang-format patch
diff --git a/utility/SPIDEV/gpio.cpp b/utility/SPIDEV/gpio.cpp
index 6da8d99..792e19b 100644
--- a/utility/SPIDEV/gpio.cpp
+++ b/utility/SPIDEV/gpio.cpp
@@ -80 +80 @@ void GPIO::write(int port, int value)
- memset(&rq, 0, sizeof(rq)); // This is needed to set to default values apparently
+ memset(&rq, 0, sizeof(rq)); // This is needed to set to default values apparently
@@ -82 +82 @@ void GPIO::write(int port, int value)
-
+
@@ -92 +92 @@ void GPIO::write(int port, int value)
-
+
@@ -99 +99 @@ void GPIO::write(int port, int value)
-
+
@@ -102 +102 @@ void GPIO::write(int port, int value)
-
+
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Cpp-linter Review
Click here for the full clang-format patch
diff --git a/utility/SPIDEV/gpio.cpp b/utility/SPIDEV/gpio.cpp
index 471144b..6bb6e54 100644
--- a/utility/SPIDEV/gpio.cpp
+++ b/utility/SPIDEV/gpio.cpp
@@ -80 +80 @@ void GPIO::write(int port, int value)
- memset(&rq, 0, sizeof(rq)); // This is needed to set to default values apparently
+ memset(&rq, 0, sizeof(rq)); // This is needed to set to default values apparently
@@ -82 +82 @@ void GPIO::write(int port, int value)
-
+
@@ -92 +92 @@ void GPIO::write(int port, int value)
-
+
@@ -99 +99 @@ void GPIO::write(int port, int value)
-
+
Have any feedback or feature suggestions? Share it here.
|
This one can wait a little bit for testing etc, but it seems to work fine, only some minor changes to the v1 API code |
|
Oh I see you already did a better job of this in another branch @2bndy5 ... LOL |
|
Yes but it doesn't work. The request type and/or struct passed to |
|
Did you get it working with the |
|
ok, well I took some pointers from this branch and got mine working. But I really think we should cache the FD for both chip and used gpio lines. My RPi4 runs slightly slower with the new GPIO changescompared to to my RPi3 using v1.4.8 (without new gpio changes)Its worse on my RPi3 using the new GPIO changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to v2 API re #942 #943