Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRQ support using Linux kernel Character Device + Posix threads #961

Merged
merged 31 commits into from
Mar 19, 2024
Merged

IRQ support using Linux kernel Character Device + Posix threads #961

merged 31 commits into from
Mar 19, 2024

Commits on Mar 13, 2024

  1. move chip info into GPIOChipCache struct

    @2bndy5
    2bndy5 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e434507 View commit details
    Browse the repository at this point in the history

  2. make gpioCache static in gpio.h

    @2bndy5
    2bndy5 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    af70aa8 View commit details
    Browse the repository at this point in the history

  3. use pthread & poll with Linux kernel's char-dev API

    @2bndy5
    2bndy5 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    32f7803 View commit details
    Browse the repository at this point in the history

  4. fix segfault; avoid using extern funcs

    @2bndy5
    2bndy5 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    abe8d25 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. use pthread_cancel instead; fix ISR callback trigger

    @2bndy5
    2bndy5 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ed289b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. don't release pin upon exiting attachInterrupt()

    @2bndy5
    2bndy5 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    678a144 View commit details
    Browse the repository at this point in the history

  2. remove unneccessary config flags for FALLING edge detetction

    @2bndy5
    2bndy5 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    bbd5680 View commit details
    Browse the repository at this point in the history

  3. clear the edge event from kernel buffer

    @2bndy5
    2bndy5 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    ec92ac5 View commit details
    Browse the repository at this point in the history

  4. [example] change IRQ_PIN number and flush cout stream before pin_n_wa… 

    …it()
    @2bndy5
    2bndy5 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    995bca5 View commit details
    Browse the repository at this point in the history

  5. IRQ example timeout 

    - Add timeout to interrupt example
    @TMRh20
    TMRh20 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    004291e View commit details
    Browse the repository at this point in the history

  6. don't poll(); just read() and track event sequence number

    @2bndy5
    2bndy5 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    870d3a6 View commit details
    Browse the repository at this point in the history

  7. [example] use endl instead of flush

    @2bndy5
    2bndy5 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    03661b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. code cleanup (in all Linux driver files) 

    remove unused `#include` and reorder so that std/external libs are pre-processed first
    @2bndy5
    2bndy5 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    cf6d5f2 View commit details
    Browse the repository at this point in the history

  2. review IRQ support in Linux drivers 

    - switch RPi driver to char-dev IRQ
- wrap wiringPiIsr() into attachInterrupt()
- adjust build system generators (lib and examples)
- use IRQException instead of GPIOException
- make defined RF24_LINUX_GPIO_CHIP more agnostic of selected driver (applied to RPi and SPIDEV drivers)
- fix compiling wiringPi with examples using old makefile
- update URL in examples_linux/README
- remove explicit wiringPi from list of linked libs in pyRF24/setup.py
    @2bndy5
    2bndy5 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    a066d0c View commit details
    Browse the repository at this point in the history

  3. increase event buffer size; only zero-out irqEventInfo once

    @2bndy5
    2bndy5 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    bd48742 View commit details
    Browse the repository at this point in the history

  4. re-enable wiringPi driver in Linux CI using old makefile build

    @2bndy5
    2bndy5 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    b950a42 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Apply suggestions from clang-format code review 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @2bndy5 @github-actions
    2bndy5 and github-actions[bot] committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b74f17e View commit details
    Browse the repository at this point in the history

  2. rearrange pre-processor statements in a header file

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bf2282c View commit details
    Browse the repository at this point in the history

  3. disable wiringPi in linux CI 

    I am not going to try cross-compiling dependencies of dependencies. WiringPi needs libs: crypt and rt compiled for the target system.
    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1322530 View commit details
    Browse the repository at this point in the history

  4. reviewed Linux CI (again)

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7ff5565 View commit details
    Browse the repository at this point in the history

  5. [CI] fix typo in path

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9aa37b3 View commit details
    Browse the repository at this point in the history

  6. some initial code review

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f8decf1 View commit details
    Browse the repository at this point in the history

  7. prefer using time.h

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e56ecf4 View commit details
    Browse the repository at this point in the history

  8. remove INT_EDGE_SETUP define (wiringPi-specific meaning)

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4f79413 View commit details
    Browse the repository at this point in the history

  9. review includes for RF24_arch_config.h files

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0b80565 View commit details
    Browse the repository at this point in the history

  10. add C linkage instead of declaring extern functions

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5ab12b0 View commit details
    Browse the repository at this point in the history

  11. more #include statements review

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c3845f7 View commit details
    Browse the repository at this point in the history

  12. reviewed wiringPi/spi wrapper

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d81439f View commit details
    Browse the repository at this point in the history

  13. move gpiochipX init out of cache c'tors 

    this should fix the issue with loading pyRF24 modules( downstream) when building docs.

There should be negligible performance hit as most of this init stuff (`pinMode()` and `attachInterrupt()`) only takes place at user space startup.
Although, devs that dynamically allocate pins (with `RF24::begin(CE, CSN)`) will see a performance cost.
    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7973ba6 View commit details
    Browse the repository at this point in the history

  14. add wiringPi pin number for CE_PIN to linux examples

    @2bndy5
    2bndy5 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0df788c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. wait for thread to terminate before closing pin fd

    @2bndy5
    2bndy5 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3b3187a View commit details
    Browse the repository at this point in the history