Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inline lambda code #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

jfrconley
Copy link
Contributor

@jfrconley jfrconley commented Nov 20, 2023

Problem

Inline lambda code was not correctly supported

Solution

Create a virtual asset that gets uploaded as inline code

Test Plan:

  • Covered by existing tests
  • New coverage added
  • Special instructions for testing described below

Documentation:

  • No documentation required
  • Additional documentation required below

Additional Notes:

N/A

Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: 81736b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nrfcloud/cdktf-aws-adaptor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.81% 3468 / 3949
🔵 Statements 87.81% 3468 / 3949
🔵 Functions 73.5% 172 / 234
🔵 Branches 78.28% 328 / 419
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/mappings/services/lambda.ts 100% 96.77% 75% 100%
Generated in workflow #10

@savvyintegrations
Copy link
Contributor

@jfrconley As we never really got this working, and decided to switch to NodejsFunction, what do you want to do w/ this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants