Skip to content

Commit

Permalink
fix: retrieve sale model if possible #275
Browse files Browse the repository at this point in the history
  • Loading branch information
Jin committed Jan 24, 2024
1 parent 359f9e6 commit d6df494
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions homebridge-ui/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class UiServer extends HomebridgePluginUiServer {
id: device.deviceId,
name: device.alias,
type: constants.DeviceType[device.deviceType],
serial_number: device.manufacture?.salesModel,
};
}),
};
Expand Down
4 changes: 2 additions & 2 deletions src/baseDevice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ export class baseDevice extends EventEmitter {
) {
super();

const device = accessory.context.device;
const device: Device = accessory.context.device;
const {AccessoryInformation} = this.platform.Service;
const serviceAccessoryInformation = accessory.getService(AccessoryInformation) || accessory.addService(AccessoryInformation);

// set accessory information
serviceAccessoryInformation
.setCharacteristic(this.platform.Characteristic.Manufacturer, 'LG')
.setCharacteristic(this.platform.Characteristic.Model, device.model || 'Unknown')
.setCharacteristic(this.platform.Characteristic.Model, device.salesModel || device.model || 'Unknown')
.setCharacteristic(this.platform.Characteristic.SerialNumber, this.config.serial_number || device.serialNumber || 'Unknown');
}

Expand Down
4 changes: 4 additions & 0 deletions src/lib/Device.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ export class Device {
return this.data.manufacture?.macAddress;
}

public get salesModel(){
return this.data.manufacture?.salesModel;
}

public get serialNumber() {
return this.data.manufacture?.serialNo;
}
Expand Down

0 comments on commit d6df494

Please sign in to comment.