Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to make package compatible with Laravel 5.1 #33

Closed
wants to merge 1 commit into from

Conversation

anaxamaxan
Copy link
Contributor

Main changes in this pull request:

  1. Update DbExportHandlerServiceProvider::boot() and ::register() methods to use the L5 config publishes() style. This allows the config to get published via php artisan vendor:publish.
  2. Remove the $this->package('nwidart/db-exporter'); call from DbMigrationsServiceProvider::boot() method. It's enough to have it publishes() call in the export handler, so leave it empty.
  3. Register \Str alias in DbExportHandlerServiceProvider::loadAlias() because some users won't have \Str alias registered in their config/app.php, and you're already going the extra mile, so might as well do it for \Str too.
  4. Replace config strings using L4 style, e.g. Config::get('db-exporter::export_path.seeds') --> config('db-exporter.export_path.seeds')
  5. Replace Config::get() with config() just to be more consistent with Laravel docs.

@anaxamaxan anaxamaxan changed the title Updates to make package compatible with Laravel 5.2 Updates to make package compatible with Laravel 5.1 Dec 19, 2015
@anaxamaxan
Copy link
Contributor Author

oops, there's an incorrect config path... I'll resubmit this PR

@anaxamaxan anaxamaxan closed this Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant