Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failure Tests #1764

Merged
merged 33 commits into from
Mar 16, 2024
Merged

Fix Failure Tests #1764

merged 33 commits into from
Mar 16, 2024

Conversation

alissn
Copy link
Contributor

@alissn alissn commented Mar 15, 2024

Hi,

This PR should be merged after #1758, #1762. 🚀

Continuing from the updates in #1758 and #1762, this pull request focuses on refining the module structure.

In #1758 and #1762, all tests passed without any failures! 🤯 Upon deeper inspection of the test configuration, hardcoded paths were identified in the generator section here.

To resolve this issue, I've modified this section to read from the module config. Consequently, most tests failed 🥲.

I've updated all tests to pass and included additional necessary tests. Additionally, the issue with the unit-test command not working has been fixed. 🛠️

alissn and others added 30 commits March 7, 2024 13:26
@alissn alissn marked this pull request as draft March 15, 2024 20:53
@dcblogdev dcblogdev marked this pull request as ready for review March 16, 2024 23:33
@dcblogdev dcblogdev merged commit c011088 into nWidart:master Mar 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants