Skip to content
This repository has been archived by the owner on Apr 9, 2023. It is now read-only.

Migrate TSLint to ESLint #61

Merged
merged 16 commits into from
Jul 6, 2022
Merged

Migrate TSLint to ESLint #61

merged 16 commits into from
Jul 6, 2022

Conversation

gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Jun 16, 2022

fix #49

Migrate to ESLint from TSLint.

  • Replace with ESLint commands in npm scripts.
  • Uninstall TSLint and install ESLint and additional packages as Shogi.js.
  • ESLint config is cited from the Shogi.js one.
  • Ignore .github, test directory in npm ignore file as Shogi.js
  • Add .prettierignore. Note that src/__tests__/jkfplayerTest.ts is temporary ignored, since the jest run somehow fails if it is linted.
  • Add .prettierrc.json as Shogi.js.
  • Update README.md link from TSLint to ESLint.
  • Lint and format some files according to ESLint and Prettier rules.
    • Some rules are ignored by inserting ESLint line comments.
  • Add a test case since the coverage check fails.

@gemmaro gemmaro marked this pull request as ready for review June 18, 2022 11:31
@na2hiro na2hiro merged commit 727b1a2 into na2hiro:master Jul 6, 2022
@na2hiro
Copy link
Owner

na2hiro commented Jul 6, 2022

Thank you for migrating to ESLint!

@na2hiro na2hiro mentioned this pull request Jul 6, 2022
@gemmaro gemmaro deleted the eslint branch July 6, 2022 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tslint to eslint
2 participants