Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon #182

Merged
merged 1 commit into from Apr 27, 2021
Merged

Add favicon #182

merged 1 commit into from Apr 27, 2021

Conversation

mehdichaouch
Copy link
Contributor

@mehdichaouch mehdichaouch commented Apr 25, 2021

Fix this error:

pi@nabaztag:~/pynab/nabweb/static $ tail -f /var/log/daemon.log
Apr 25 19:02:25 nabaztag gunicorn[576]: Not Found: /favicon.ico

favicon

@nabaztag2018
Copy link
Owner

Hello, there's a requirement error on pytz. I just merged a new fix, maybe can you update your repository and push the PR again ?

@mehdichaouch
Copy link
Contributor Author

mehdichaouch commented Apr 26, 2021

@nabaztag2018 you merged PR #181 , but Build #779 in Travis CI is still in error !
That's not a problem ?

As I see bug came from wm8960 driver and there is fix is here : pguyot/wm8960#9 from @f-laurens, so just need to be tested/merged by @pguyot 🤔

@nabaztag2018
Copy link
Owner

Nope :-)

@mehdichaouch
Copy link
Contributor Author

@f-laurens I rebased my PR on master 😃.

@nabaztag2018 this one is ready for reviewing 💚.

@nabaztag2018
Copy link
Owner

Today is my 🎂, it's merge day 🥳

@nabaztag2018 nabaztag2018 merged commit a196448 into nabaztag2018:master Apr 27, 2021
@mehdichaouch
Copy link
Contributor Author

mehdichaouch commented Apr 27, 2021

YEAH 🎉 🥂 @nabaztag2018 @omevel 54 🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️🕯️ 😉

tenor

@mehdichaouch
Copy link
Contributor Author

it's merge day 🥳

@nabaztag2018 maybe it'll be also a release day? 🤩

@mehdichaouch mehdichaouch deleted the favicon branch May 8, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants