Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Add Pull Request auto labelling #244

Merged
merged 1 commit into from
May 26, 2021

Conversation

mehdichaouch
Copy link
Contributor

@mehdichaouch mehdichaouch marked this pull request as ready for review May 23, 2021 12:37
@omevel omevel merged commit cfa5caf into nabaztag2018:master May 26, 2021
@mehdichaouch mehdichaouch deleted the pr-labeler branch May 26, 2021 08:56
@f-laurens
Copy link
Contributor

f-laurens commented May 26, 2021

@mehdichaouch @omevel: what is this mess with this Pull Request Labeler?
(see https://github.com/nabaztag2018/pynab/pull/250/checks?check_run_id=2674876798)
Was it tested before merge?

Please disable this workflow until the problem is fixed...

@mehdichaouch
Copy link
Contributor Author

mehdichaouch commented May 26, 2021

I just pushed a fix #251.
I tested the workflow in my fork, but after test I change labels introducing this typo bug.
Sorry for this mess 😕

@omevel
Copy link
Collaborator

omevel commented May 26, 2021

It does not seem to pass the test. Can you check ? Thanks !

@f-laurens
Copy link
Contributor

@omevel: can you just disable this workflow in GitHub Actions till the problem is fixed?

@omevel
Copy link
Collaborator

omevel commented May 26, 2021

done

@mehdichaouch
Copy link
Contributor Author

@omevel: can you just disable this workflow in GitHub Actions till the problem is fixed?

Respectfully @f-laurens there is no emergecy PR to be merge so why asking to disable it?

@f-laurens
Copy link
Contributor

so why asking to disable it?

Because a workflow that doesn't work is a real nuisance and a loss of time for everyone, that's all...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants