Use absolute paths for permissions check #693

nabeelio · May 15, 2020 · 77d7ffb · 77d7ffb
1 parent 78ee1a9
commit 77d7ffb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 15 deletions.
diff --git a/modules/Installer/Config/config.php b/modules/Installer/Config/config.php
@@ -26,16 +26,16 @@
 
     // Make sure these are writable
     'permissions' => [
-        'bootstrap/cache',
-        'public/uploads',
-        'storage',
-        'storage/app/public',
-        'storage/app/public/avatars',
-        'storage/app/public/uploads',
-        'storage/framework',
-        'storage/framework/cache',
-        'storage/framework/sessions',
-        'storage/framework/views',
-        'storage/logs',
+        base_path('bootstrap/cache'),
+        public_path('uploads'),
+        storage_path(),
+        storage_path('app/public'),
+        storage_path('app/public/avatars'),
+        storage_path('app/public/uploads'),
+        storage_path('framework'),
+        storage_path('framework/cache'),
+        storage_path('framework/sessions'),
+        storage_path('framework/views'),
+        storage_path('logs'),
     ],
 ];
diff --git a/modules/Installer/Resources/views/install/index-start.blade.php b/modules/Installer/Resources/views/install/index-start.blade.php
@@ -2,7 +2,6 @@
 @section('title', 'Install phpVMS')
 
 @section('content')
-  <h2>phpvms installer</h2>
   <p>Press continue to start</p>
   {{ Form::open(['route' => 'installer.step1', 'method' => 'post']) }}
   <p style="text-align: right">

diff --git a/modules/Installer/Services/RequirementsService.php b/modules/Installer/Services/RequirementsService.php
@@ -55,9 +55,8 @@ public function checkPermissions(): array
         clearstatcache();
 
         $directories = [];
-        foreach (config('installer.permissions') as $dir) {
+        foreach (config('installer.permissions') as $path) {
             $pass = true;
-            $path = base_path($dir);
 
             if (!file_exists($path)) {
                 $pass = false;
@@ -68,7 +67,7 @@ public function checkPermissions(): array
             }
 
             $directories[] = [
-                'dir'    => $dir,
+                'dir'    => $path,
                 'passed' => $pass,
             ];
         }