Put hint on email fields, etc, when editing user not to prefill

[ymnoor21]

Describe the bug

I am one of the admins of my VA. So when trying to approve a pilot application by editing the user, I see my email address in the user editor screen.

Version

version 7.0.0-dev

To Reproduce

Steps to reproduce the behavior:

1. You need to have a pending pilot application.
2. VIsit: https://<yourdomain.com>/admin/users?search=state:0
3. Edit the user.
4. Check the email address and password field. It shows the admin email, not the user email.

Expected behavior

This should show the user's email and not the admin email. Moreover, the password field shouldn't be here. Users already have that functionality from the login screen with the "Forget Password" link. Password change should not be an admin functionality.

Better yet, add an approve button on the user list page. You can always go edit the user to set a different status.

Screenshots

I cannot share the screenshot because of the user's data privacy.

[FatihKoz]

I tried to replicate the issue, it works as it should ... I see the user email and not admin email.

Registered with a fake/test user to my test server;

And clicked edit to see the result;

It is the email I used during registration, not my admin e-mail.

Moreover, the password field shouldn't be here.

And I think it should be there, it does not show the user's password BUT will give admins the ability to assist users if they are not able to change their password etc for some reason or when it is really needed. So in my opinion it should be there and that should be an admin functionality too.

Btw, latest dev version is 7.0.0-dev+210423.ec6cb4 dated 23 APR 2021 ... I assume you are using that too (and I never saw my admin email during approval of users)

[nabeelio]

Hmm yeah I'm not seeing my admin email there either on the demo. Strange. The password field will be there since the admin can reset it to something if needed

[FatihKoz]

Is this happening to all users ? Maybe that user entered the admin email on purpose ? The email field is unique but if the admin email is not used in the users table someone can use it during registration. Or maybe another admin changed it to test something but forgot to switch it back ?

On 3 May 2021 Mon at 17:03 Nabeel S. ***@***.***> wrote: Hmm yeah I'm not seeing my admin email there either on the demo. Strange. The password field will be there since the admin can reset it to something if needed — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARXKVMLNWLDSXQY3KQMRPATTL2UMNANCNFSM4374DTOA> .

-- B. Fatih KOZ Sent from mobile device / Mobil cihaz ile gonderildi.

[ymnoor21]

Guys, this might be an issue with my browser prefilling it. So if you have used the browser option to save the username and password for the login screen, it shows up in the user edit screen. I tried incognito and found the issue, otherwise, it didn't show the admin email. So it may not be an issue after all. Sorry about this. Please close this issue if you want.

[FatihKoz]

Glad you figured it out :)

On 3 May 2021 Mon at 18:26 Yamin Noor ***@***.***> wrote: Guys, this might be an issue with my browser prefilling it. So if you have used the browser option to save the username and password for the login screen, it shows up in the user edit screen. I tried incognito and found the issue, otherwise, it didn't show the admin email. So it may not be an issue after all. Sorry about this. Please close this issue if you want. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARXKVMK43NAOPMZ5KT5TBGLTL26BJANCNFSM4374DTOA> .

-- B. Fatih KOZ Sent from mobile device / Mobil cihaz ile gonderildi.

[nabeelio]

Ah, so I changed the title of this, I think then I have to add something to those input boxes so that the browser won't autofill those.