Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin : Save Pirep Button Generates Error | FareService (Bug Report) #1233

Closed
FatihKoz opened this issue Jun 6, 2021 · 0 comments · Fixed by #1291
Closed

Admin : Save Pirep Button Generates Error | FareService (Bug Report) #1233

FatihKoz opened this issue Jun 6, 2021 · 0 comments · Fixed by #1291

Comments

@FatihKoz
Copy link
Contributor

FatihKoz commented Jun 6, 2021

Describe the bug
When saving an already accepted pirep, below error occurs.

[2021-06-06 21:12:26] prod.ERROR: Attempt to assign property 'pirep_id' of non-object 
{"userId":3,"exception":"[object] (ErrorException(code: 0): Attempt to assign property 'pirep_id' of non-object at /app/Services/FareService.php:311)

Version
7.0.0-dev+210604.96d33c

To Reproduce
Steps to reproduce the behavior:

  1. Go to admin -> pireps
  2. Click on one of the accepted pireps
  3. Do not edit anything (most of the fields are already read only, if you wish edit some possible fields like notes/remarks)
  4. Scroll down enough to see the SAVE button
  5. Click on it (either you will see the error or famous server error screen depending on APP_DEBUG)

Expected behavior
Well, as the button says , it should save ... At least if nothing is change either we should not see that button or it should revert back without saving anything. But getting an error is not expected at all

Additional Info
The pirep I tried was a fresh one, there were no changes done to the fares related to that pirep. It was just receieved from Acars, auto accepted, I went in to check some details and clicked the save button by mistake.

This error is also reported by one of the users at Discord and we all thought that he deleted a fare or something related to that pirep.

@FatihKoz FatihKoz changed the title Admin : Save Pirep Button Generates Error (FareService) Admin : Save Pirep Button Generates Error | FareService (Bug Report) Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant