Fix Admin / PirepController

[FatihKoz]

$fares was an array but was being handled like a collection , which of course was causing problems while assigning a value to $fare->pirep_id and with the $fare->save() calls.

PR fixes both and Closes #1233 and #1244

[nabeelio]

Thanks... actually the right place to fix this is in PirepController in the Admin section in saveFares. It should do something like:

new PirepFare([
    'fare_id' => $fare->id,
    'count'   => 100,
]);

Matching the PirepController in the frontend

[nabeelio]

Nice find!

[FatihKoz]

Thanks... actually the right place to fix this is in PirepController in the Admin section in saveFares. It should do something like:

new PirepFare([
    'fare_id' => $fare->id,
    'count'   => 100,
]);

Matching the PirepController in the frontend

It may be... Actually I just tracked the error, then followed it back two/three steps and to be honest did not thought on better solutions... It was done there before but not working, somehow you designed it to be there :) I just fixed.

[nabeelio]

Yep just fix it in the controller, then the service file changes can be undone.

[FatihKoz]

So moving all that delete and re-save code back to admin controller and then leaving the service as it was before ?

No problem :)

[FatihKoz]

Ready as you wished.