Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.php in root on install #156

Closed
4 tasks done
nabeelio opened this issue Jan 29, 2018 · 0 comments
Closed
4 tasks done

Add config.php in root on install #156

nabeelio opened this issue Jan 29, 2018 · 0 comments

Comments

@nabeelio
Copy link
Owner

nabeelio commented Jan 29, 2018

Add it to get parsed and override any configs, vs adding them all manually in several places in the env.php file. Mainly for forward compatibility and easier to upgrade, don't need to touch any of the files in the config/ folder. E.g:

return [
  # overrides the app.php config file
  'app' => [
    'name' => 'phpVMS Airlines',
  ],
];

tasks

  • See ServiceProvider::mergeConfigFrom
  • See \Illuminate\Support\Arr
  • create stub in installer
    • move database/mail settings
  • move phpvms settings
  • read and parse in AppServiceProvider (replace the local.config.php entry)
  • docs

Sample file: https://gist.github.com/nabeelio/a93b062121a29647efe43b3508ccffe8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant