Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend search schedule options #297

Closed
avs-code opened this issue Mar 17, 2019 · 3 comments · Fixed by #506 or #496
Closed

Extend search schedule options #297

avs-code opened this issue Mar 17, 2019 · 3 comments · Fixed by #506 or #496
Labels
enhancement
Milestone
7.0.0

Comments

@avs-code
Copy link
Contributor

In the new phpvms v7 there are only search by:

  • flight num
  • dep.airport
  • arr.airport

In the old phpvms there were by:

  • dep.airport
  • arr.airport
  • aircraft type
  • distance

It would be fantastic to include the old ones in addition to adding the distance by range, between "x" miles and "y" miles. Since the phpvms v2 only has the option of greater than "x" or less than "x", not both.
@nabeelio
Copy link
Owner

nabeelio commented May 8, 2019 •
edited
Loading

Add HTML elements, and then to here: app/Repositories/FlightRepository.php::73

nabeelio added a commit that referenced this issue May 10, 2019
@nabeelio
Add greater than/less than search options #297
5b061ba
nabeelio added a commit that referenced this issue May 11, 2019
@nabeelio
Merge pull request #306 from nabeelio/issue-297/search-options
b8d4f4e 
Add more search criteria/dev environment via docker-compose #297
@stale
Copy link

stale bot commented Jul 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 7, 2019
@stale stale bot closed this as completed Jul 14, 2019
@nabeelio nabeelio reopened this Jul 15, 2019
@stale stale bot removed the wontfix label Jul 15, 2019
@stale
Copy link

stale bot commented Sep 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 13, 2019
@nabeelio nabeelio added this to the beta-2 milestone Sep 16, 2019
@stale stale bot removed the wontfix label Sep 16, 2019
@nabeelio nabeelio modified the milestones: beta-2, 7.x Oct 23, 2019
This was linked to pull requests Feb 12, 2020
Search flights by subfleet #484 #506
Merged
Flight search for departure/arrival airports not using column names #496
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
7.0.0
2 participants
@nabeelio @avs-code