Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuel cost only allows whole numbers for price #342

Closed
ProAviaAZ opened this issue Aug 6, 2019 · 3 comments
Closed

Fuel cost only allows whole numbers for price #342

ProAviaAZ opened this issue Aug 6, 2019 · 3 comments
Labels
Milestone

Comments

@ProAviaAZ
Copy link

ProAviaAZ commented Aug 6, 2019

Presently, fuel cost can only be set to a whole number. As cost is per pound of fuel, should allow setting decimals also. Two decimal places should work.

Jet fuel at $0.85/pound would be approximately $5.69/gallon (0.85 * 6.7lbs/gal).

Possibly all cost can be set to accommodate two decimal places.... ground handling, fuel, and all other costs.

Hopefully, this is possible.

@nabeelio
Copy link
Owner

nabeelio commented Aug 6, 2019

If you can, check out the issue/342-fuel-prices branch

nabeelio added a commit that referenced this issue Aug 6, 2019
* Add step fields to enable decimal points on fields #342

* Update js-yaml version due to vulnerability scan

* Don't seed dev files when env == local

* Fix

* Fix  to be static

* Add visibilty keyword
@ProAviaAZ
Copy link
Author

Prices can now be entered in 2 point decimal format. I have not checked if they are computed correctly, just that they can be entered.

@nabeelio
Copy link
Owner

nabeelio commented Aug 7, 2019

Great, thanks!

@nabeelio nabeelio closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants