-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow logo upload for airline #417
Comments
Marking this as post-beta. I'm going to come back to this and probably have a logo upload or something like that, and then show it on that page like you said. I guess I just had a logo link there in-case someone wanted to use it in their template |
And should it be an icon-sized thing? What do you invision for this? |
So allow any size, etc? |
I'd restrict this to 180x40px, which seems a reasonable value. It would be nice if the upload function would preserve the aspect ratio and pad any open space that is left. |
On second thought, it might be wise to have a large version (say 360x80) and a smaller version, so upload at least 360x80 px image and save it twice. |
Yes. You can always use CSS to scale the image. 180 x 40 or 180x50 is a great size for the schedules and flight lists. On the detailed list maybe bigger logos should be used. The question here is where logos should come up in general? So far with VAs I have been looking at, the logos were only visible in the schedule... but nowhere else. |
@voipmeister @bbuske Following up on this - do you guys want a logo upload, or is that link to the logo ok? |
Describe the bug
As requested via Discord: You can enter logos for the airlines when you create / edit them. However, these logos are not visible in the front end, like at the flight page.
Version
7.0.0 including the latest dev release.
To Reproduce
Try to add a logo locally and add a link to it or link to one from an external source like Wikipedia. The logo will not show up.
Expected behavior
After adding a link to the logo, external or local, the logo of the airline should show up at the flights page and on other places.
Cheers
The text was updated successfully, but these errors were encountered: