Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logo upload for airline #417

Closed
bbuske opened this issue Oct 26, 2019 · 8 comments · Fixed by #550
Closed

Allow logo upload for airline #417

bbuske opened this issue Oct 26, 2019 · 8 comments · Fixed by #550
Milestone

Comments

@bbuske
Copy link
Contributor

bbuske commented Oct 26, 2019

Describe the bug
As requested via Discord: You can enter logos for the airlines when you create / edit them. However, these logos are not visible in the front end, like at the flight page.

Version
7.0.0 including the latest dev release.

To Reproduce
Try to add a logo locally and add a link to it or link to one from an external source like Wikipedia. The logo will not show up.

Expected behavior
After adding a link to the logo, external or local, the logo of the airline should show up at the flights page and on other places.

Cheers

@nabeelio nabeelio added this to the 7.0.0 milestone Oct 29, 2019
@nabeelio
Copy link
Owner

Marking this as post-beta. I'm going to come back to this and probably have a logo upload or something like that, and then show it on that page like you said. I guess I just had a logo link there in-case someone wanted to use it in their template

@nabeelio
Copy link
Owner

And should it be an icon-sized thing? What do you invision for this?

@bbuske
Copy link
Contributor Author

bbuske commented Oct 30, 2019

Well just airline logos in searches for flights and other listings, where it is mentioned... something like this:
image

@nabeelio
Copy link
Owner

So allow any size, etc?

@voipmeister
Copy link
Contributor

I'd restrict this to 180x40px, which seems a reasonable value. It would be nice if the upload function would preserve the aspect ratio and pad any open space that is left.

@nabeelio nabeelio changed the title Logos not showing Allow logo upload for airline Nov 1, 2019
@voipmeister
Copy link
Contributor

On second thought, it might be wise to have a large version (say 360x80) and a smaller version, so upload at least 360x80 px image and save it twice.
Would be nice to be able to use either version in the code (smaller version in tables for example).

@bbuske
Copy link
Contributor Author

bbuske commented Nov 2, 2019

Yes. You can always use CSS to scale the image. 180 x 40 or 180x50 is a great size for the schedules and flight lists. On the detailed list maybe bigger logos should be used.

The question here is where logos should come up in general? So far with VAs I have been looking at, the logos were only visible in the schedule... but nowhere else.

@nabeelio
Copy link
Owner

@voipmeister @bbuske Following up on this - do you guys want a logo upload, or is that link to the logo ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants