Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updater not working because Source repository [github] is not defined #575

Closed
jcabala14 opened this issue Feb 23, 2020 · 6 comments
Closed

Updater not working because Source repository [github] is not defined #575

jcabala14 opened this issue Feb 23, 2020 · 6 comments
Labels
bug
Milestone
7.0.0

Comments

@jcabala14
Copy link
Contributor

Describe the bug
When try to update phpVMS 7.0.0 beta 3, source repository doesn't configure.
InvalidArgumentException: Source repository [github] is not defined.

Version
phpVMS 7.0.0

To Reproduce
Steps to reproduce the behavior:

  1. Go to admin/maintenance
  2. Click on Update button.
  3. Click on Run button.
  4. See error.

Expected behavior
Expected autoupdate phpvms version.

Screenshots
image
@nabeelio
Copy link
Owner

What version are on you specificially? There won't be a update available but this error shouldn't be showing up anyway

@nabeelio nabeelio added the bug label Feb 23, 2020
@nabeelio nabeelio added this to the 7.0.0 milestone Feb 23, 2020
nabeelio added a commit that referenced this issue Feb 23, 2020
@nabeelio
Check for null version from upstream #575
7ea1bd2
@nabeelio nabeelio mentioned this issue Feb 23, 2020
Merged
@nabeelio
Copy link
Owner

Oh, you'll need the latest dev version for this to work. It'll attempt to upgrade from dev to beta, though that'll actually be a downgrade. This functionality will only work on release versions.

@jcabala14
Copy link
Contributor Author

Perfect nabeelio!

I have the latest version of commits from the dev branch to try the application and help in issues report ^^

@nabeelio
Copy link
Owner

No problem, thanks! I actually found a different bug with versioning issues. But I'm not sure why you're still getting that error. Do you have a config/self-update.php file? Is the repository stuff all filled in pointing to this repo?

nabeelio added a commit that referenced this issue Feb 23, 2020
@nabeelio
Split get/generate build ID #575
9093650
@jcabala14
Copy link
Contributor Author

Yep, I have this file with this code (only paste repository part):

'type' => 'github', 'repository_vendor' => 'nabeelio', 'repository_name' => 'phpvms', 'repository_url' => 'https://github.com/nabeelio/phpvms', 'download_path' => storage_path('app'), 'private_access_token' => '', 'use_branch' => '',

nabeelio added a commit that referenced this issue Feb 23, 2020
@nabeelio
Upstream null version; build version tags not being saved properly #575…
0e13905 
… (#578)

* Check for null version from upstream #575

* Fix for pre-release version numbering

* Move popup to right

* Split get/generate build ID #575
@nabeelio
Copy link
Owner

I'll close this for now, when I release the next beta (maybe tomorrow) we can see if it'll work properly when updating from dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@nabeelio @jcabala14